[tarantool-patches] Re: [PATCH v1 1/6] Update the timeouts, set to use the default value

[Alexander Turenko]

>  -- Check that garbage collection removed the snapshot once
>  -- the replica released the corresponding checkpoint.
> -wait_gc(1) or box.info.gc()
> -wait_xlog(1) or fio.listdir('./master') -- Make sure the replica will not receive data until
> +wait_gc(1)
> +wait_xlog(1)
>  -- we test garbage collection.

This is the poorly formatted comment that spread across two lines:

-- Make sure the replica will not receive data until
-- we test garbage collection.

Please, add it back.

> diff --git a/test/replication/master.lua b/test/replication/master.lua
> index 9b96b7891..340b9cc81 100644
> --- a/test/replication/master.lua
> +++ b/test/replication/master.lua
> @@ -3,7 +3,7 @@ os = require('os')
>  box.cfg({
>      listen              = os.getenv("LISTEN"),
>      memtx_memory        = 107374182,
> -    replication_connect_timeout = 0.5,
> +    replication_connect_timeout = 100,
>      replication_timeout = 0.1
>  })
>  

replication_connect_timeout = 30 is not enough?

> diff --git a/test/replication/master_quorum.lua b/test/replication/master_quorum.lua
> index 05272ac5e..e00f1f932 100644
> --- a/test/replication/master_quorum.lua
> +++ b/test/replication/master_quorum.lua
> @@ -6,7 +6,7 @@ local INSTANCE_ID = string.match(arg[0], "%d")
>  local SOCKET_DIR = require('fio').cwd()
>  
>  local TIMEOUT = tonumber(arg[1])
> -local CON_TIMEOUT = arg[2] and tonumber(arg[2]) or 30.0
> +local CON_TIMEOUT = arg[2] and tonumber(arg[2]) or 60.0
>  
>  local function instance_uri(instance_id)
>      --return 'localhost:'..(3310 + instance_id)
> diff --git a/test/replication/on_replace.lua b/test/replication/on_replace.lua
> index 40c12a9ea..93544afbe 100644
> --- a/test/replication/on_replace.lua
> +++ b/test/replication/on_replace.lua
> @@ -7,7 +7,7 @@ local PASSWORD = 'somepassword'
>  local SOCKET_DIR = require('fio').cwd()
>  
>  local TIMEOUT = tonumber(arg[1])
> -local CON_TIMEOUT = arg[2] and tonumber(arg[2]) or 30.0
> +local CON_TIMEOUT = arg[2] and tonumber(arg[2]) or 60.0

Really? 30 in not enough? Maybe we just increase a propability that
another problem will be passed through?

> -test_run:cmd('start server quorum1 with args="0.1  0.5"')
> +test_run:cmd('start server quorum1 with args="0.1 0.5"')

Should not we drop latter argument here too to use default 30 seconds
replication_connect_timeout?

> diff --git a/test/replication/rebootstrap.lua b/test/replication/rebootstrap.lua
> index 3e7d8f062..472dbe453 100644
> --- a/test/replication/rebootstrap.lua
> +++ b/test/replication/rebootstrap.lua
> @@ -6,7 +6,7 @@ local INSTANCE_ID = string.match(arg[0], "%d")
>  local SOCKET_DIR = require('fio').cwd()
>  
>  local TIMEOUT = tonumber(arg[1])
> -local CON_TIMEOUT = arg[2] and tonumber(arg[2]) or 30.0
> +local CON_TIMEOUT = arg[2] and tonumber(arg[2]) or 60.0

Same question as above.

> @@ -131,9 +131,9 @@ box.info.ro -- false
>  -- ER_CFG "duplicate connection with the same replica UUID" error.
>  -- It should print it to the log, but keep trying to synchronize.
>  -- Eventually, it should leave box.cfg() following the master.
> -box.cfg{replication_timeout = 0.1}
> -box.cfg{replication_sync_lag = 1}
> -box.cfg{replication_sync_timeout = 10}
> +box.cfg{replication_timeout = 0.01}
> +box.cfg{replication_sync_lag = 0.1}
> +box.cfg{replication_sync_timeout = 50}

Don't get why replication_timeout and replication_sync_lag was
decreased.