[tarantool-patches] Re: [PATCH v1 1/1] sql: check access rights of table in VIEW

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Wed Apr 24 17:22:04 MSK 2019


LGTM.

On 24/04/2019 17:02, Kirill Shcherbatov wrote:
> On 24.04.2019 16:48, Vladislav Shpilevoy wrote:
>> Thanks for the patch!
>>> +test_run = require('test_run').new()
>>
>> 1. You do not use this object, so it can be omitted.
> 
>> 2. You pass here box.cfg.listen directly, without splitting into
>> parts.
>>
>> Please, consider my review fixes below and on the branch:
> 
> Looks good for me, thanks. Amend.
> 




More information about the Tarantool-patches mailing list