[tarantool-patches] Re: [PATCH v1 2/3] sql: remove unused macros in SQL

Imeev Mergen imeevma at tarantool.org
Thu Apr 11 19:56:31 MSK 2019


Hi! Thank you for review! My answers below.

On 4/11/19 3:08 AM, n.pettik wrote:
>
>> On 9 Apr 2019, at 20:17, imeevma at tarantool.org wrote:
>>
>> Thise macros unused and should be removed.
> Nit: these.
>
> Nit: are unused.
Thanks, will fix.
>
> Are you sure that you’ve removed *all* unused macros?
> Otherwise, which attribute are you used to spot this group
> of macros?
Definitely not all. I started with main.c. Should I remove all
unused macros or just add to the commit-message that these macros
are from main.c?




More information about the Tarantool-patches mailing list