[tarantool-patches] Re: [PATCH v1 3/3] sql: remove unused functions from main.c

[Konstantin Osipov]

* imeevma at tarantool.org <imeevma at tarantool.org> [19/04/09 20:19]:
> -int
> -sql_shutdown(void)

This could be actually useful when debugging memory leaks, Nikita,
what's your take?

> -/*
> - * This API allows applications to modify the global configuration of
> - * the sql library at run-time.
> - *
> - * This routine should only be called when there are no outstanding
> - * database connections or memory allocations.  This routine is not
> - * threadsafe.  Failure to heed these warnings can lead to unpredictable
> - * behavior.
> - */
> -int
> -sql_config(int op, ...)
> -{

This is OK to remove.

> -/*
> - * Cause any pending operation to stop at its earliest opportunity.
> - */
> -void
> -sql_interrupt(sql * db)
> -{
> -	db->u1.isInterrupted = 1;
> -}

This could also be useful.

The rest of the patch is looking good to me. Let's wait for
Nikita's review. 

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov