[tarantool-patches] Re: [PATCH 7/6] swim: drop incarnation_inc parameter from update() routines

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Apr 18 23:40:46 MSK 2019


Pushed into the master.

On 18/04/2019 21:20, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/04/18 21:18]:
>> Update_addr and update_payload need to increment member's
>> incarnation when it is self. For that they used a special
>> parameter incarnation_inc set in 1 for self and in 0 for others.
>>
>> It was used to encapsulate incarnation update + event scheduling
>> on member attribute updates, but on the other hand it broke
>> another encapsulation level - there should not be exceptions for
>> 'self' in these functions.
>>
>> This patch makes incarnation increment explicit in the places
>> where 'self' is updated.
> 
> ok to push
> 
> -- 
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
> 




More information about the Tarantool-patches mailing list