[tarantool-patches] Re: [PATCH 1/1] test: drop invalid assert from swim test transport

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Apr 30 02:27:44 MSK 2019


Pushed to the master as trivial.

On 30/04/2019 02:27, Vladislav Shpilevoy wrote:
> The assertion was checking that a next event object is not the
> same as the previous, but
> 
>     1) the previous was deleted already to this moment;
>     2) comparison was done by pointer
> 
> The first problem would be enough to drop it. The second is
> already curious - looks like after the old event was deleted,
> the next event was allocated right on the same memory. This is
> why their pointers are equal and the assertion fails.
> 
> For example, swim_timer_event_process() - it deletes the event
> object and calls ev_invoke() which can generate a new event on
> the just freed memory.




More information about the Tarantool-patches mailing list