[tarantool-patches] Re: [PATCH v2 1/1] tap: fix is_deeply box.NULL corner cases

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Wed Apr 24 15:02:32 MSK 2019



On 24/04/2019 14:57, Alexander Turenko wrote:
>> @@ -163,6 +173,7 @@ local function is_deeply(test, got, expected, message, extra)
>>      extra = extra or {}
>>      extra.got = got
>>      extra.expected = expected
>> +    extra.strict = test.strict
> 
> The 'extra' parameter is needed to provide a user more information in
> case of a fail. Here we use it to push options for cmpdeeply(). I would
> add 'opts' parameter instead.
> 

If you do not like extra output about 'strict' value, then we
could make it 'nil' by default, not 'false', and it will not
be printed until someone starts to use it.




More information about the Tarantool-patches mailing list