[tarantool-patches] Re: [PATCH v4 3/3] box: introduce multikey indexes in memtx

[Konstantin Osipov]

* Vladimir Davydov <vdavydov.dev at gmail.com> [19/04/30 12:43]:
> > > That would emphasize that it inserts a single multikey entry.
> > 
> > I like "memtx_tree_index_replace_multikey_step". What do you think?
> 
> Better _one or _do_replace IMO :) We typically use _one suffix for
> splitting functions like that in the code; _step sounds like it is
> about iterators while it is not.

_one or replace_one_key

> > >> +/**
> > >> + * Check if child_field may be attached to parent_field,
> > >> + * update the parent_field container type if required.
> > >> + */
> > >> +static int
> > >> +tuple_field_ensure_child_compatibility(struct tuple_field *parent,
> > >> +				       struct tuple_field *child)
> > > 
> > > Wouldn't tuple_format_check_field be a better name?
> > I am not shure.
> > This code not only check some cases, but also may change field type
> > when it is possible.
> > "enshure compatibility" -- make everything okey or die

then split it into two functions?


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32