[PATCH 03/13] vinyl: store tuple comparison hints in tx write set

Vladimir Davydov vdavydov.dev at gmail.com
Thu Apr 4 15:21:42 MSK 2019


On Thu, Apr 04, 2019 at 02:41:17PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev at gmail.com> [19/04/02 20:35]:
> > This patch incorporates tuple comparison hints into the transaction
> > write set. Now, beside a statement, each txv also stores its hint,
> > which is used in all comparison operations.
> 
> Actually, the more I look at this patch set the more an object
> representing a pair <tuple, hint> (vy_key?) is called for.
> Please consider adding it, it could be passed around by value.

This could be reasonable, but I don't quite like the name vy_key,
because in vinyl we have a different concept of keys.

A few names that pop into mind:

	vy_kv.{stmt,val}
	vy_hinted_stmt.{tuple,val}
	vy_indexed_stmt.{tuple,val}

Any other suggestions?

Will have to rework this patch set, I guess :(



More information about the Tarantool-patches mailing list