[tarantool-patches] Re: [PATCH 2/2] swim: expose ping broadcast API

[Konstantin Osipov]

* Konstantin Osipov <kostja at tarantool.org> [19/04/11 16:00]:
> * Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [19/04/10 21:01]:
> > +/**
> > + * Broadcast a ping to all interfaces on a specified @a port. If
> > + * @a port is < 0, then a port of the SWIM instance is used.
> > + */
> 
> Please add to the comment information about possible errors -
> memory allocation error or there are no interfaces available for
> broadcast. Mention what errors are not detected since the
> broadcast itself happens asynchronously - errors related to
> writing to network, these are simply ignored.
> 
> > +int
> > +swim_broadcast(struct swim *swim, int port);

Otherwise the patch is OK to push.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov