[PATCH] lib/core/coio_file: Use eio_sendfile_sync instead of a chunk mode

Cyrill Gorcunov gorcunov at gmail.com
Fri Apr 12 17:42:12 MSK 2019


On Fri, Apr 12, 2019 at 05:19:16PM +0300, Vladimir Davydov wrote:
...
> > But I agree that using sendfile here actually may trim file. I'll take
> > a look at evening but I think we should rather use sendfile with offsets
> > in a cycle. Seriouly, using 4K buffer is the worst possible algo :)
> 
> Yeah, it would be great to make use of sendfile, but we must make sure
> we won't occasionally break anything.

I will have to update tests. The problem only is that we've to test
big files here, have no clue if our CI engine will allow us to
generate/copy such sizes.



More information about the Tarantool-patches mailing list