[tarantool-patches] Re: [PATCH v1 1/3] sql: remove legacy.c

[n.pettik]

> @@ -1704,11 +1704,13 @@ sql_analysis_load(struct sql *db)
> 	info.db = db;
> 	info.stats = stats;
> 	info.index_count = 0;
> -	const char *load_stat1 =
> +	MAYBE_UNUSED const char *load_stat1 =
> 		"SELECT \"tbl\",\"idx\",\"stat\" FROM \"_sql_stat1\"";
> -	/* Load new statistics out of the _sql_stat1 table. */
> -	if (sql_exec(db, load_stat1, analysis_loader, &info, 0) != 0)
> -		goto fail;
> +	/*
> +	 * Here was loading new statistics out of the _sql_stat1
> +	 * table using analysis_loader. This part of code was
> +	 * removed due to removal of sql_exec().
> +	 */

Which mechanism will replace this functionality?
Now I don’t see any alternatives. Personally I’d
remove this function on demand: when we
introduce replacement to analysis_loader().