[tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool

[Alexander Turenko]

Hi!

See below.

WBR, Alexandr Turenko.

On Tue, Sep 11, 2018 at 10:38:38AM +0300, Nikita Tatunov wrote:
> Hello, thank you for comments.
> See full diff is at the end of the letter.
> 
> >>>> 
> >>>> -					     "ESCAPE expression must be a single character",
> >>>> +					     "ESCAPE expression must be a"
> >>>> +					     " single character",
> >>> Do not split error messages at the middle of a sentence. It makes errors ungreppable.
> >>> Make it <80 somehow different.
> >>> 
> >> 
> >> Have already been discussed in this thread.
> > I suppose that we concluded to try to fit into 80 and split the string only
> > in case it is impossible.
> 
> I don’t think so. Anyways, Alexander could you please give your thoughts?

Nikita P. gives key_def.c as the example where we don't create constant
variables in the case. We shouldn't here too I think. At least it should
not be enforced.