[tarantool-patches] Re: [PATCH] box: add a method to check if transaction is open

[Alexander Turenko]

Hi, Roman!

Sorry for the late response.

Please, consider comments below.

WBR, Alexander Turenko.

On Tue, Sep 11, 2018 at 02:51:19PM +0300, Kirill Shcherbatov wrote:
> Now LGTM. Sasha, please, take a look.
> 
> >> commit 14fa90d195dc84df21a41c3172d2f0a2e0ca68e2
> >> Author: Roman Khabibov <roman.habibov1 at yandex.ru>
> >> Date: Fri Sep 7 02:54:28 2018 +0300
> >>
> >>     box: add a method to check if txn is open
> >>
> >>     Closes: #3518.
> >>

> >> +box.is_in_txn = function()
> >> + return { builtin.box_txn() }
> >> +end
> >> +

Why do you return a table with boolean, but not boolean?

> >> diff --git a/test/engine/savepoint.result b/test/engine/savepoint.result
> >> index a62a2e1..00d281b 100644
> >> --- a/test/engine/savepoint.result
> >> +++ b/test/engine/savepoint.result
> >> @@ -14,7 +14,7 @@ s1 = box.savepoint()
> >>  ...
> >>  box.rollback_to_savepoint(s1)
> >>  ---
> >> -- error: 'builtin/box/schema.lua:340: Usage: box.rollback_to_savepoint(savepoint)'
> >> +- error: 'builtin/box/schema.lua:346: Usage: box.rollback_to_savepoint(savepoint)'
> >>  ...
> >>  box.begin() s1 = box.savepoint()
> >>  ---
> >> @@ -323,27 +323,27 @@ test_run:cmd("setopt delimiter ''");
> >>  ok1, errmsg1
> >>  ---
> >>  - false
> >> -- 'builtin/box/schema.lua:340: Usage: box.rollback_to_savepoint(savepoint)'
> >> +- 'builtin/box/schema.lua:346: Usage: box.rollback_to_savepoint(savepoint)'
> >>  ...
> >>  ok2, errmsg2
> >>  ---
> >>  - false
> >> -- 'builtin/box/schema.lua:340: Usage: box.rollback_to_savepoint(savepoint)'
> >> +- 'builtin/box/schema.lua:346: Usage: box.rollback_to_savepoint(savepoint)'
> >>  ...
> >>  ok3, errmsg3
> >>  ---
> >>  - false
> >> -- 'builtin/box/schema.lua:340: Usage: box.rollback_to_savepoint(savepoint)'
> >> +- 'builtin/box/schema.lua:346: Usage: box.rollback_to_savepoint(savepoint)'
> >>  ...
> >>  ok4, errmsg4
> >>  ---
> >>  - false
> >> -- 'builtin/box/schema.lua:340: Usage: box.rollback_to_savepoint(savepoint)'
> >> +- 'builtin/box/schema.lua:346: Usage: box.rollback_to_savepoint(savepoint)'
> >>  ...
> >>  ok5, errmsg5
> >>  ---
> >>  - false
> >> -- 'builtin/box/schema.lua:340: Usage: box.rollback_to_savepoint(savepoint)'
> >> +- 'builtin/box/schema.lua:346: Usage: box.rollback_to_savepoint(savepoint)'
> >>  ...
> >>  s:select{}
> >>  ---
> > 

It is better to use output filtering feature of test-run to avoid such
redundant diffs.

Consider test/app/socket.test.lua:

```
 12 env = require('test_run')
 13 test_run = env.new()
 14 test_run:cmd("push filter '(error: .builtin/.*[.]lua):[0-9]+' to '\\1'")
```

It is not a blocker for that patch, but if you intend to include it, do
it in the separate commit before 'add a method to check if txn is open'.