[tarantool-patches] Re: [PATCH 2/2] test: add output filtering feature

[Alexander Turenko]

Hi!

Minor comments are below.

WBR, Alexander Turenko.

On Fri, Sep 21, 2018 at 03:54:42AM +0300, roman.habibov1 at yandex.ru wrote:
> 
> Add output filtering feature for engine/savepoint.test.
> 
> Part of #3518.
> ---
> commit b8be4c51e29110f459bd58dba51d6546cd9da25b
> Author: Roman Khabibov <roman.habibov1 at yandex.ru>
> Date:   Fri Sep 21 03:28:04 2018 +0300
> 
>     test: add output filtering feature
> 

Please, describe the change in less abstract manner, like 'test: filter
line numbers from engine/savepoint'. Now the description looks like you
are implement this feature from scratch.

> diff --git a/test/engine/savepoint.test.lua b/test/engine/savepoint.test.lua
> index de8f297..9d4be7f 100644
> --- a/test/engine/savepoint.test.lua
> +++ b/test/engine/savepoint.test.lua
> @@ -1,5 +1,6 @@
>  env = require('test_run')
>  test_run = env.new()
> +test_run:cmd("push filter '(.builtin/.*).lua:346' to '\\1.lua:340'")
>  

Tricky thing :)

It is better to remove line numbers entirely as socket.test.lua does and
update the result file, because the current approach does not protect us
from the next line numbers change.

Also I propose to place this commit before 'box: add a method to check
if txn is open' to achieve two points:

* each commit passes the tests (can be useful when someone will bisect
  some problem in the future and is generally recommended way);
* don't need to update the test result twice (update line numbers, then
  remove line numbers).