[tarantool-patches] Re: [PATCH v1 1/1] sql: assertion in autoincrement column

Konstantin Osipov kostja at tarantool.org
Sat Sep 29 07:27:20 MSK 2018


* imeevma at tarantool.org <imeevma at tarantool.org> [18/09/28 19:18]:
>  		pOut = &aMem[pOp->p2];
> -		MemSetTypeFlag(pOut, MEM_Int);
> +		/*
> +		 * Flag should be MEM_Int but in some cases it can
> +		 * have an other value. See gh-3670.
> +		 */
> +		MemSetTypeFlag(pOut, pIn1->flags);

Please make the comment more explicit. I should not have to dig
into commit history and find the relevant test case to understand
what's going on here.

>  
>  		pOut->u.i = pIn1->u.i;
>  	}
-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov




More information about the Tarantool-patches mailing list