[tarantool-patches] Re: [PATCH 3/7] vinyl: add global disk stats

[Konstantin Osipov]

* Vladimir Davydov <vdavydov.dev at gmail.com> [18/09/02 23:23]:
> This patch adds some essential disk statistics to box.stat.vinyl().
> The new statistics are reported under the 'disk' section and currently
> include the following fields:
> 
>  - data_files: number of open data files (*.run).
>  - data_size: size of data stored on disk.
>  - index_size: size of index stored on disk.
>  - dump_total: number of bytes written by dump tasks.
>  - compact_total: number of bytes writted by compaction tasks.

How about also maintaining statistics about the amount of
garbage, i.e. runs removed from an LSM but maintained 'cause of
checkpoint or backup?

These stats would also be useful on per index basis.


The patch itself is OK to push.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov