[tarantool-patches] Re: [PATCH 2/2] replication: don't stop syncing on configuration errors

[Vladimir Davydov]

On Wed, Sep 26, 2018 at 01:29:44AM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev at gmail.com> [18/09/24 14:07]:
> > When replication is restarted with the same replica set configuration
> > (i.e. box.cfg{replication = box.cfg.replication}), there's a chance that
> > an old relay will be still running on the master at the time when a new
> > applier tries to subscribe. In this case the applier will get an error:
> 
> On the flip side once this change is made a really invalid
> configuration (duplicate connection with the same replica id)
> won't lead to an immediate disconnect. But since we continue
> logging the error before applier_disconnect(), the user will still see:
> 
> >   main/152/applier/localhost:62649 I> can't join/subscribe
> >   main/152/applier/localhost:62649 xrow.c:891 E> ER_CFG: Incorrect value for
> >       option 'replication': duplicate connection with the same replica UUID
> 
> assuming this message is still printed it's OK to push.

The error message is still printed.

Pushed both patches to 1.10.