[tarantool-patches] Re: [PATCH 07/11] vinyl: do not account zero dump bandwidth

[Konstantin Osipov]

* Vladimir Davydov <vdavydov.dev at gmail.com> [18/09/20 12:39]:
> Since we free memory in 16 MB blocks (see SLAB_SIZE), it may occur that
> we dump almost all data stored in a block but still have to leave it be,
> because it contains data of a newer generation. If the memory limit is
> small (as it is typically in tests), this may result in dumping 0 bytes.
> In order not to disrupt statistics and throttling transactions in vain,
> let's simply ignore such results. Normally, the memory limit should be
> large enough for such granularity not to affect the measurements
> (hundreds of megabytes) so this problem isn't worth putting more efforts
> into.

OK to push, obviously, except you have no place to apply this
patch since I haven't approved the set of patches it is based on.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov