[tarantool-patches] Re: [PATCH v1 3/3] sql: dissallow bindings for DDL

Kirill Shcherbatov kshcherbatov at tarantool.org
Tue Sep 11 10:21:55 MSK 2018

> ‘''
> Could we keep previous error message? It looks satisfactory actually.
> The same for triggers: could we use message like
> “Failed to create trigger ‘…’: parameters prohibited in trigger definition”?
> Or present your persuasive arguments :)
> ‘’’
> I ‘member that we discussed smth about error messages but really
> can’t recall exactly what. So, please, answer on this nit or fix it.
The previous error message was set elsewhere in other place, on resolve.
Now this is a part of parser that doesn't now, which AST does it compile. And this 
should be done uniformly.

> This test should be moved to test/sql/triggers.test.lua
> (Since this test is about checks only).
Ohm, okey. Separate tests per one ticket is a bigger evil for me.
As you wish. I've fixed it.

More information about the Tarantool-patches mailing list