[tarantool-patches] Re: [PATCH v1 3/3] sql: dissallow bindings for DDL

Kirill Shcherbatov kshcherbatov at tarantool.org
Thu Sep 13 09:13:11 MSK 2018


> -
> -
> 
> Noise diff.
Ok.

> You forgot to drop table t5.
It isn't required as this attempt to create t5 should fail that is a test scenario.

>  box.sql.execute("DROP TABLE t;")
> +
> +
> 
> One new line is redundant.
Ok.

> 
> The rest *obviously* LGTM.
Kirill, let's merge It.




More information about the Tarantool-patches mailing list