[tarantool-patches] Re: [PATCH 2/2] sql: add test on changes/total_changes

Alex Khatskevich avkhatskevich at tarantool.org
Mon Oct 1 19:13:09 MSK 2018

>> I have expected the same thing.
>> However:
>> 1. sqlite works in the same way.
> It doesn’t mean anything. SQLite features a wide range of really strange things.
>> 2. implementing this just need adding (nChanges) to savepoint
> Seems so, but it shouldn’t be complicated.
I suppose it is not complicated.
>> 3. I suppose that we should not implement this.
> Why? I guess it is matter of discussion.
I think that it is not important, because it is relatively useless counter.
1. No one need to count exact number of changes.
2. Changing the api require solid understanding of what total_changes is
     and why we need to change this.
     It strange for me that it do not do rollback on rollback, however, 
it meant to work this
     way and it also makes sense.
> Anyway, I propose to decide what to do with TOTAL_CHANGES within this patch,
> since original issue sounds like:
> "Fix if easy, remove otherwise.”
> Adding initially wrong tests is likely to be huge mistake.
This thing works. Tests proof that.
I believe that those tests are the artefact of this issue.
If you want change something, you need to file an issue and explain,
why this change is important.

More information about the Tarantool-patches mailing list