[tarantool-patches] Re: [PATCH 1/3] sql: delete unused code

n.pettik korablev at tarantool.org
Tue Oct 2 16:36:41 MSK 2018


> diff --git a/src/box/sql/main.c b/src/box/sql/main.c
> index 782f99452..3a01f1207 100644
> --- a/src/box/sql/main.c
> +++ b/src/box/sql/main.c
> @@ -483,105 +483,6 @@ setupLookaside(sqlite3 * db, void *pBuf, int sz, int cnt)
> 	return SQLITE_OK;
> }
> 
> -/*
> - * Free up as much memory as we can from the given database
> - * connection.
> - */
> -int
> -sqlite3_db_release_memory(sqlite3 * db)

You forgot to delete function declaration from sqliteInt.h

> @@ -712,12 +613,6 @@ sqlite3_close(sqlite3 * db)
> 	return sqlite3Close(db, 0);
> }
> 
> -int
> -sqlite3_close_v2(sqlite3 * db)
> -{
> -	return sqlite3Close(db, 1);
> -}

You deleted not all mentions of sqlite3_close_v2(), just grep it.





More information about the Tarantool-patches mailing list