[tarantool-patches] Re: [PATCH 1/2] sql: fix typo in MakeRecord memory hint

n.pettik korablev at tarantool.org
Mon Oct 1 03:12:34 MSK 2018


LGTM.

> On 27 Sep 2018, at 15:39, AKhatskevich <avkhatskevich at tarantool.org> wrote:
> 
> Part of: #2181
> Related to: #3021
> ---
> Issue: https://github.com/tarantool/tarantool/issues/3021
> 
> src/box/sql/update.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/box/sql/update.c b/src/box/sql/update.c
> index 730872fc6..1069f62cb 100644
> --- a/src/box/sql/update.c
> +++ b/src/box/sql/update.c
> @@ -276,9 +276,9 @@ sqlite3Update(Parse * pParse,		/* The parser context */
> 								pPk->def);
> 		sqlite3VdbeAddOp4(v, OP_MakeRecord, iPk, pk_part_count,
> 				  regKey, zAff, pk_part_count);
> -		sqlite3VdbeAddOp2(v, OP_IdxInsert, iEph, regKey);
> 		/* Set flag to save memory allocating one by malloc. */
> 		sqlite3VdbeChangeP5(v, 1);
> +		sqlite3VdbeAddOp2(v, OP_IdxInsert, iEph, regKey);
> 	}
> 	/* End the database scan loop.
> 	 */
> --





More information about the Tarantool-patches mailing list