Re: [PATCH v2] test: disable feedback daemon test on Mac OS in CI

Сергей Воронежский sergw at tarantool.org
Wed Oct 10 10:55:21 MSK 2018


LGTM


>Среда, 10 октября 2018, 1:17 +03:00 от Alexander Turenko <alexander.turenko at tarantool.org>:
>
>The fail is known and should not have any influence on our CI results.
>
>The test should be enabled back after a fix of #3558.
>---
>
>https://github.com/tarantool/tarantool/issues/3558
>https://github.com/tarantool/tarantool/commits/Totktonada/gh-3558-disable-feedback-daemon-test-mac-os
>https://travis-ci.org/tarantool/tarantool/builds/439377915
>
> test/box-tap/feedback_daemon.skipcond | 8 ++++++++
> 1 file changed, 8 insertions(+)
> create mode 100644 test/box-tap/feedback_daemon.skipcond
>
>diff --git a/test/box-tap/feedback_daemon.skipcond b/test/box-tap/feedback_daemon.skipcond
>new file mode 100644
>index 000000000..778c8a135
>--- /dev/null
>+++ b/test/box-tap/feedback_daemon.skipcond
>@@ -0,0 +1,8 @@
>+import os
>+import platform
>+
>+# Disabled on Mac OS in CI due to flaky fail #3558.
>+if os.environ.get('TRAVIS_JOB_ID', '') and platform.system() == 'Darwin':
>+    self.skip = 1
>+
>+# vim: set ft=python:
>-- 
>2.19.0
>


-- 
Сергей Воронежский
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20181010/9160b2ba/attachment.html>


More information about the Tarantool-patches mailing list