[tarantool-patches] Re: [PATCH v2 1/2] box: added replication_dead/rw_gap options

[Olga Arkhangelskaia]

15/10/2018 13:22, Vladimir Davydov пишет:
> On Fri, Oct 12, 2018 at 10:45:56PM +0300, Olga Arkhangelskaia wrote:
>> In scope of gh-3110 we need options that store periods of time,
>> to be compared with time of last activity of relay and applier.
>> This patch introduces replication_dead_gap and replication_rw_gap options.
>>
>> replication_dead_gap is configured in box.cfg, with default 0 value.
>> If time that passed from now till last reader/writer activity of given replica
>> exceeds replication_dead_gap value, replica is suspected to be dead.
>> replication_dead_gap is measured in hours.
>>
>> replication_rw_gap is configured in box.cfg, with default 0 value.
>> If time difference between last reader activity and last writer activity of
>> given replica exceeds replication_rw_gap value, replica is suspected to be dead.
>> replication_rw_gap is measured in hours.
> Why would you even need these configuration options? Why can't you
> simply pass these parameters as function arguments?
Hi, I thought it would be more convinient. But now, as you asked my why...
You are right, it is easier to pass value you want to trace. Will throw 
them away.

> Anyway, we typically configure a timeout in seconds, not in hours, and
> use TIMEOUT_INFINITY for infinite timeout, not 0.
Ok, than seconds will be left.