[tarantool-patches] Re: [PATCH 0/2] First part of SQLite error codes refactoring

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Wed Oct 3 23:04:12 MSK 2018

Hi! Thanks for the patchset!

Unfortunately, SQLITE_IOERR and CONSTRAINT are not the only
error codes. Please, look at enum sql_ret_code in sqliteInt.h

All of these codes are errors too and should be refactored
alongside with this patch - I mean SQLITE_OK, SQLITE_ERROR,
SQLITE_PERM etc. Strictly speaking, I think SQLITE_OK should
be removed and be replaced with inlined 0 as it is done in
other parts of Tarantool.

On 02/10/2018 23:50, AlexeyIvushkin wrote:
> From: Morgan-iv <ivushkinalex at gmail.com>
> These 2 patches are the beginning of SQLite error codes refactoring.
> Both of them change implementation of affected error codes from
> define macro to enum statement, and remove codes that aren't returned
> anywhere, but first also remove related function that aren't called
> anywhere too. First patch affects SQLITE_IOERR_ codes, second -
> Final rename of all error codes affected in these 2 patches and
> the next several patches in this branch will be applied after removing
> all unused error codes and removing all found unused functions related
> to affected SQLite error codes
> Issue: https://github.com/tarantool/tarantool/issues/3315
> Branch: https://github.com/tarantool/tarantool/tree/Morgan-iv/gh-3315
> Morgan-iv (2):
>    sql: refactor SQLITE_IOERR_ error codes
>    sql: remove unused SQLITE_CONSTRAINT_ error codes
>   src/box/sql/main.c      | 51 ----------------------------
>   src/box/sql/os_unix.c   | 88 -------------------------------------------------
>   src/box/sql/sqliteInt.h | 56 ++++++++++++-------------------
>   3 files changed, 21 insertions(+), 174 deletions(-)

More information about the Tarantool-patches mailing list