[PATCH 05/13] gc: fold gc_consumer_new and gc_consumer_delete

Vladimir Davydov vdavydov.dev at gmail.com
Fri Oct 5 11:56:03 MSK 2018


On Fri, Oct 05, 2018 at 12:50:04AM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev at gmail.com> [18/10/05 00:11]:
> > gc_consumer_new is used in one place while gc_consumer_delete is used in
> > two places, but it's a one-liner. Let's fold them to make the code flow
> > more straightforward.
> 
> Can't agree with you on unrestricted use of free(), it's a time
> bomb, please keep gc_consumer_delete().

OK I'll leave gc_consumer_delete() and add gc_checkpoint_delete(),
which will be a wrapper around free() too, in the patch that introduces
gc_checkpoint struct, for consistency.



More information about the Tarantool-patches mailing list