[tarantool-patches] [PATCH v2 0/2] sql: check read access while executing SQL query

Kirill Yukhin kyukhin at tarantool.org
Fri Oct 12 14:38:17 MSK 2018


This patchset intended to fix checking of read priviledges
while executing SQL queries. To do so, box interface for
fetching space pointer by name was replaced by requesting
(created in 1st patch) dedicated mapping of space name to
space pointer. This allows SQL machinery to read from system
spaces w/o any access checks. Actual check is performed by
IteratorOpen op-code.

https://github.com/tarantool/tarantool/commits/kyukhin/gh-2362-sql-read-access-check                                                                                                        
https://github.com/tarantool/tarantool/issues/2362

Kirill Yukhin (2):
  Add space names cache
  sql: check read access while executing SQL query

 src/box/alter.cc                              |  18 +--
 src/box/schema.cc                             | 123 +++++++++++++++---
 src/box/schema.h                              |  12 +-
 src/box/sql/alter.c                           |  11 +-
 src/box/sql/analyze.c                         |  44 +++----
 src/box/sql/build.c                           |  57 +++-----
 src/box/sql/delete.c                          |  26 ++--
 src/box/sql/insert.c                          |   7 +-
 src/box/sql/pragma.c                          |  32 ++---
 src/box/sql/vdbe.c                            |   5 +
 test/box/stat.result                          |   6 +-
 test/sql/gh-2362-select-access-rights.result  | 110 ++++++++++++++++
 .../sql/gh-2362-select-access-rights.test.lua |  42 ++++++
 13 files changed, 353 insertions(+), 140 deletions(-)
 create mode 100644 test/sql/gh-2362-select-access-rights.result
 create mode 100644 test/sql/gh-2362-select-access-rights.test.lua

-- 
2.19.1





More information about the Tarantool-patches mailing list