[PATCH] replication: keep header when request is modified by before_replace
kostja at tarantool.org
Mon Oct 29 23:45:26 MSK 2018
* Vladimir Davydov <vdavydov.dev at gmail.com> [18/10/29 20:25]:
> When space.before_replace trigger modifies the result of a remote
> operation, we clear the request header so that it gets rebuilt on
> commit. This is incorrect, because as a result we don't bump the
> master's component of the replica's vclock, which leads to the request
> being applied again when the replica reconnects. The issue manifests
> itself in sporadic replication/before_replace test failures.
> Fix it by updating the request header rather than clearing it so that
> replica id and lsn get preserved.
> Closes #3722
OK to push.
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
More information about the Tarantool-patches