[tarantool-patches] Re: [PATCH 0/3] Delete foreign_keys and ignore_check_constraints pragmas

[Kirill Yukhin]

Hello,
On 02 Oct 13:48, AKhatskevich wrote:
> Issue: https://github.com/tarantool/tarantool/issues/3696
> Branch: https://github.com/tarantool/tarantool/tree/kh/gh-3696-delete-pragmas-2
> 
> Those pragmas let a user turn off constraint checks.
> They are considered useless and dangerous.
> 
> AKhatskevich (3):
>   sql: delete unused code
>   sql: delete foreign_keys pragma
>   sql: delete ignore_check_constraints pragma
> 
>  src/box/sql.c                             |   3 +-
>  src/box/sql/CMakeLists.txt                |   1 -
>  src/box/sql/fkey.c                        |  21 +--
>  src/box/sql/insert.c                      |   7 +-
>  src/box/sql/main.c                        | 291 ------------------------------
>  src/box/sql/pragma.h                      |  14 --
>  src/box/sql/sqliteInt.h                   |  19 +-
>  test/sql-tap/check.test.lua               |  15 +-
>  test/sql-tap/tkt-b1d3a2e531.test.lua      |   8 +-
>  test/sql-tap/triggerC.test.lua            |   5 +-
>  test/sql/transitive-transactions.result   |   3 -
>  test/sql/transitive-transactions.test.lua |   1 -
>  12 files changed, 12 insertions(+), 376 deletions(-)
I've checked the patchset of 3 commits into 2.0 branch.
Your branch contained extra commit, which didn't pass review
so far. I've kicked it. (I didn't delete the branch because of
that)

--
Regards, Kirill Yukhin

> 
> -- 
> 2.14.1
> 
>