[tarantool-patches] Re: [PATCH v7 1/2] sql: return all generated ids via IPROTO

[Imeev Mergen]

Hi! Thank you for review! My answer below.

On 10/29/18 1:17 PM, Vladislav Shpilevoy wrote:
> Hi!
>
> On 27/10/2018 15:43, imeevma at tarantool.org wrote:
>> According to documentation some JDBC functions have an ability to
>> return all ids that were generated in executed INSERT statement.
>> This patch gives a way to implement such functionality.
>>
>> Closes #2618
>> ---
>
> Do not omit branch and issue name.
>
> Why did not you send the second commit?
>
> Now I see, that it would be better to split this commit
> into 2 parts: factoring fiber_gc() out of txn_commit and
> auto-generated ids. I did it already and force pushed on the
> branch.
>
> But it appeared that tests fail with this reproduce
> file:
>
> ========================= rep.yaml ===========================
>
> ---
> - [sql/select-null.test.lua, memtx]
> - [sql/errinj.test.lua, memtx]
> - [sql/persistency.test.lua, memtx]
> - [sql/errinj.test.lua, vinyl]
> - [sql/gh-2929-primary-key.test.lua, vinyl]
> - [sql/message-func-indexes.test.lua, vinyl]
> - [sql/drop-table.test.lua, memtx]
> - [sql/gh2808-inline-unique-persistency-check.test.lua, memtx]
> - [sql/transitive-transactions.test.lua, memtx]
> - [sql/max-on-index.test.lua, vinyl]
> - [sql/iproto.test.lua, vinyl]
> - [sql/checks.test.lua, vinyl]
> - [sql/triggers.test.lua, memtx]
> - [sql/gh-3199-no-mem-leaks.test.lua, memtx]
> - [sql/savepoints.test.lua, vinyl]
> - [sql/gh2808-inline-unique-persistency-check.test.lua, vinyl]
>
> ================================================================
>
> python test-run.py --reproduce rep.yaml
>
> [001] Test failed! Result content mismatch:
> [001] --- sql/gh-3199-no-mem-leaks.result    Thu Oct 25 22:58:31 2018
> [001] +++ sql/gh-3199-no-mem-leaks.reject    Mon Oct 29 13:12:35 2018
> [001] @@ -27,7 +27,7 @@
> [001]  ...
> [001]  fiber.info()[fiber.self().id()].memory.used
> [001]  ---
> [001] -- 0
> [001] +- 4036
> [001]  ...
>
> It repeats both on your branch and on my force
> pushed version. Please, fix.
>
This problem is described in issue 3732
https://github.com/tarantool/tarantool/issues/3732

I found that mentioned yaml produces the same error on current 2.1
branch.

Due to this it was decided that issue 2618 shouldn't deal with
the problem.