[PATCH v2 4/4] wal: delete old wal files when running out of disk space
kostja at tarantool.org
Wed Oct 24 19:53:34 MSK 2018
* Vladimir Davydov <vdavydov.dev at gmail.com> [18/10/24 12:55]:
> No, this isn't true. WAL watcher was introduced as a generic
> notification channel built over cbus in the first place. Before
> it was made available, we used inotify to track WAL directory
> changes in relays.
> > Now you can send a direct message to gc. Why use wal watcher api at
> > all?
> Because we already have a generic abstraction, and I think we'd better
> use it instead of adding another wal-tx pipe to the wal_thread and
> implementing home-brewed notifications on top of it.
Well, the pipe costs nearly nothing at runtime. It is point to
point delivery. The watcher api is broadcast by nature. Can't we use
the existing pipe? We no longer delete any files on the receiving
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
More information about the Tarantool-patches