[tarantool-patches] Re: [PATCH] box: add tuple:size function

[Vladislav Shpilevoy]

On 05/10/2018 13:23, Vladimir Davydov wrote:
> On Thu, Sep 27, 2018 at 08:55:23PM +0300, AlexeyIvushkin wrote:
>> diff --git a/src/box/lua/tuple.lua b/src/box/lua/tuple.lua
>> index 63ea73e..801ee3c 100644
>> --- a/src/box/lua/tuple.lua
>> +++ b/src/box/lua/tuple.lua
>> @@ -286,6 +286,7 @@ local methods = {
>>       ["update"]      = tuple_update;
>>       ["upsert"]      = tuple_upsert;
>>       ["bsize"]       = tuple_bsize;
>> +    ["size"]        = internal.tuple.size;
>>       ["tomap"]       = internal.tuple.tuple_to_map;
> 
> Why did you decide to introduce a new function rather than fixing
> tuple.bsize, as it was explicitly requested in the ticket?

It breaks compatibility. Now bsize returns only Message Pack part
of tuple despite what the documentation says.

>