[PATCH v2 4/4] wal: delete old wal files when running out of disk space

Konstantin Osipov kostja at tarantool.org
Tue Oct 23 21:46:45 MSK 2018

* Vladimir Davydov <vdavydov.dev at gmail.com> [18/10/23 20:30]:
> +static void
> +gc_process_wal_event(struct wal_watcher_msg *msg)
> +{
> +	if ((msg->events & WAL_EVENT_GC) == 0)
> +		return;

GC is now subscribed to all events only to react to those *gc*
events which delete wal files in case of emergency.

Shouldn't gc ignore wal gc events which were initiated by
wal_collect_garbage() at least?
Why send wal_event_gc for these events?

wal watcher api is an artefact from the times when we had no
cbus connection between wal and tx. Now you can send a direct
message to gc. Why use wal watcher api at all?

Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

More information about the Tarantool-patches mailing list