[PATCH 12/13] gc: call gc_run unconditionally when consumer is advanced

Konstantin Osipov kostja at tarantool.org
Fri Oct 5 01:26:05 MSK 2018


* Vladimir Davydov <vdavydov.dev at gmail.com> [18/10/05 00:12]:
> gc_consumer_unregister and gc_consumer_advance don't call gc_run in case
> the consumer in question isn't leftmost. This code was written back when
> gc_run was kinda heavy and would call engine/wal callbacks even if it
> wouldn't really need to. Today gc_run will bail out shortly, without
> making any complex computation, let alone invoking garbage collection
> callbacks, in case it has nothing to do so those optimizations are
> pointless. Let's remove them.

OK to push.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov



More information about the Tarantool-patches mailing list