[tarantool-patches] Re: [PATCH v2 1/1] sql: hold in stat tables space/index id instead of name

n.pettik korablev at tarantool.org
Thu Oct 11 18:00:50 MSK 2018

>> Actually, this diff doesn’t look like fix of that failed test.
>> I guess it is simply flaky, so this time you get lucky and it is passed.
>> Did you checked that test-trace from Travis fails on fresh 2.0 as well?
>> Did you manage to understand the reason of failure? Otherwise there is
>> no guarantee that you patch is innocent in this situation.
>> Without any investigation I can give my approval on this patch.
> I was able to reproduce this failure on current 2.0:
> https://github.com/tarantool/tarantool/issues/3737
> I think my patch do not affect this test in the way it showed in
> error.

Ok, now that's what I'm talking about. LGTM.

More information about the Tarantool-patches mailing list