[tarantool-patches] Re: [PATCH 1/2] sql: LIKE & GLOB pattern comparison issue
alexander.turenko at tarantool.org
Thu Nov 1 13:30:45 MSK 2018
On Wed, Oct 31, 2018 at 08:25:12AM +0300, Nikita Tatunov wrote:
> > On Oct 29, 2018, at 16:01, Alexander Turenko <alexander.turenko at tarantool.org> wrote:
> > The patch is okay except one note re test case.
> > WBR, Alexander Turenko.
> >> --- EVIDENCE-OF: R-39414-35489 The infix GLOB operator is implemented by
> >> --- calling the function glob(Y,X) and can be modified by overriding that
> >> --- function.
> > This test case was removed, while we have not a similar one for LIKE.
> I guess it is concerned more with the second patch.
> Anyways. If you mean the tests following this comment then
> actually there are some similar tests for LIKE (15.1.x).
Found test cases with user-defined like function. Missed it before,
I have no more comments re this commit. Please, proceed with Nikita.
WBR, Alexander Turenko.
More information about the Tarantool-patches