[PATCH 5/6] wal: separate checkpoint and flush paths

Konstantin Osipov kostja.osipov at gmail.com
Mon Nov 26 20:58:34 MSK 2018

* Vladimir Davydov <vdavydov.dev at gmail.com> [18/11/26 10:27]:
> Currently, wal_checkpoint() is used for two purposes. First, to make a
> checkpoint (rotate = true). Second, to flush all pending WAL requests
> (rotate = false). Since checkpointing has to fail if cascading rollback
> is in progress so does flushing. This is confusing. Let's separate the
> two paths.

I agree with the two paths, but wal_flush() as a name is
confusing, since no flushing is happening. 

Let's call it wal_sync() or wal_wait() or something similar.

wal_checkpoint() could also be made more obvious and renamed to

The patch is otherwise trivial and OK to push.

Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

More information about the Tarantool-patches mailing list