[tarantool-patches] Re: [PATCH v1 6/6] sql: make sql checks on server side

[Kirill Shcherbatov]

Sorry, there are a few minor fixes that I pushed on branch.

> +	if (new_tuple != NULL && space->sql_checks != NULL) {
> +		const char *old_tuple_raw = old_tuple != NULL ?
> +					    tuple_data(old_tuple) : NULL;
> +		const char *new_tuple_raw = new_tuple != NULL ?
> +					    tuple_data(new_tuple) : NULL;
I've dropped this redundant new_tuple != NULL on branch

> +/*
> + * Terminate the current execution of an SQL statement and reset
> + * it back to its starting state so that it can be reused. A
> + * success code from the prior execution is returned.
> + *
> + * This routine sets the error code and string returned by
> + * sqlite3_errcode(), sqlite3_errmsg() and sqlite3_errmsg16().
> + */
> +int
> +sqlite3_reset(sqlite3_stmt * pStmt);
I've written doxigen comment on branch and have refactored body to follow
our codestyle.
> +static inline char *
> +sql_stmt_err(struct sqlite3_stmt *stmt)
> +{
> +	struct Vdbe *v = (struct Vdbe *)stmt;
> +	return v->zErrMsg;
> +}
I've dropped this useless routine on branch.