[tarantool-patches] Re: [PATCH v5 07/12] lib: introduce json_path_normalize routine

Vladimir Davydov vdavydov.dev at gmail.com
Tue Nov 20 18:13:03 MSK 2018


On Thu, Nov 01, 2018 at 06:27:55PM +0300, Kirill Shcherbatov wrote:
> > Let's try to avoid this altogether. We could use parent references
> > to check if path1 equals to path2.
> This required in index_def_is_valid to raise error on key_part_path_cmp == 0
> before tuple_format creation. We need to compare path strings in key_part(s)

TBO I find the idea that we have to normalize json paths just to compare
them a bit of an overkill. Why not simply introduce json_path_cmp() and
use it instead? All those functions using key_part_path_cmp() are cold
paths so that wouldn't degrade performance.



More information about the Tarantool-patches mailing list