[tarantool-patches] Re: [PATCH v1 07/10] sql: too many autogenerated ids leads to SEGFAULT

[Vladislav Shpilevoy]

Thanks for the patch! I have moved it into
new patchset to make review easier.

On 17/11/2018 17:04, imeevma at tarantool.org wrote:
> This probleam appeared because region was cleaned twice: once in
> sqlite3VdbeHalt() and once in sqlite3VdbeDelete() which was
> executed during sqlite3_finalize(). Autogenerated ids that were
> saved there, were fetched after sqlite3VdbeHalt() and before
> sqlite3_finalize(). In this patch region cleaning in
> sqlite3VdbeHalt() were removed.
> 
> Needed for #3505
> Follow up #2618
> Follow up #3199
> ---
>   src/box/sql/vdbe.c       |  8 ++------
>   src/box/sql/vdbeaux.c    |  6 ------
>   test/sql/iproto.result   | 16 ++++++++++++++++
>   test/sql/iproto.test.lua |  7 +++++++
>   4 files changed, 25 insertions(+), 12 deletions(-)
>