[tarantool-patches] [PATCH v2 0/7] Remove box.sql.execute

imeevma at tarantool.org imeevma at tarantool.org
Thu Nov 22 22:10:45 MSK 2018

The goal of this patch-set is to make functions from execute.c
the only way to execute SQL statements. This goal includes
similar output for executed SQL statements no matter how they
were executed: through net.box or through box.

This is the second version of patch-set. It is not complete. It
still has no last part, which is replacing box.sql.execute by
box.execute, because it will lead to massive test editing.

The main goal of this version of patch-set is to try new design of
box.sql.execute() and decide to leave it as it is or modify it for
better performance.


General information of difference from previous version of
- Three patches from last version were moved to different branch.
- The order in which the patches were arranged was slightly

A bit about patches of patch-set with comments about changes in
this version:

Patch 1 allows to use SQL query as plain text in sql_request.
Review fixes were made.

Patch 2 creates method for port which will allow us to dump port
directly to Lua stack. This was moved here from position 8.

Patch 3 makes function sql_response_dump() a bit more universal by
removing IPROTO functions from there. The main change from last
version is that xrow_decode_sql() was returned to execute.c.

Patch 4 allows us to design vstream by wrapping mpstream
functions. Nothing was changed for now.

Patch 5 creates interface vstream and its mpstream implementation.
Difference from previous version:
- vstream now is inherited from mpstream.
- vstream.c removed, msgpack implementation moved to mpstream.c
- Implementation of some methods were replaced by mpstream
  functions that were implicitly casted.
- encode_reply_* methods were removed. Their functionality is now
  performed by encode_enum() + encode_... + encode_map_commit().
- Flag is_flatted was moved to sql_response.

Patch 6 creates vstream implementation for Lua and defines new
box.sql.new_execute() function that will become box.execute() in
next vesions.
Difference from previous version:
- Added parameters binding for box.sql.new_execute().
- Lua implementation of vstream methods was moved to lua/sql.c.
- Changed the way errors was pushed to Lua stack.

Patch 10 is created to check that box.sql.new_execute() is able to
pass through tests created for box.sql.execute(). Almost nothing
changes from previous version.

v1: https://www.freelists.org/post/tarantool-patches/PATCH-v1-0010-sql-remove-boxsqlexecute

Kirill Shcherbatov (1):
  box: store sql text and length in sql_request

Mergen Imeev (6):
  box: add method dump_lua to port
  iproto: remove iproto functions from execute.c
  iproto: replace obuf by mpstream in execute.c
  sql: create interface vstream
  lua: create vstream implementation for Lua
  sql: check new box.sql.execute()

 src/box/execute.c      | 260 +++++++++++++++++++++++++++++++++++--------------
 src/box/execute.h      |  39 +++++---
 src/box/iproto.cc      |  31 +++++-
 src/box/lua/call.c     |   1 +
 src/box/lua/schema.lua |  23 +++++
 src/box/lua/sql.c      | 211 +++++++++++++++++++++++----------------
 src/box/port.c         |  22 +++++
 src/box/port.h         |  12 +++
 src/box/vstream.h      | 167 +++++++++++++++++++++++++++++++
 src/box/xrow.c         |  45 ---------
 src/box/xrow.h         |  19 ----
 src/mpstream.c         |  78 +++++++++++++++
 12 files changed, 673 insertions(+), 235 deletions(-)
 create mode 100644 src/box/vstream.h


More information about the Tarantool-patches mailing list