[tarantool-patches] Re: [PATCH 2/3] Add surrogate ID for BINARY collation

[Konstantin Osipov]

* Vladislav Shpilevoy <v.shpilevoy at tarantool.org> [18/11/01 15:23]:
> 
> On 01/11/2018 14:37, Konstantin Osipov wrote:
> > * n.pettik <korablev at tarantool.org> [18/10/31 18:52]:
> > 
> > Sorry for a last-minute comment, but is there any reason why id
> > has to be  4294967294? Why not use the next spare id, it's 3
> > AFAIR?
> 
> 
> I guess, because
> 
> 1) It is not real collation and is not presented in
> _collation. So for a user it would be strange to see
> a gap between 2 and 4 in _collation, which can not be
> set.

Let's insert it there.

> 2) Some advanced users could already create their own
> collations, so 3 may be occupied.

No, they couldn't.

> 3) Actually binary collation == no collation and it
> is consistent to has its ID near COLL_NONE, in a "special
> range" of collation identifiers.

Uhm, AFAIU we have two binary collations. One is "collation is not
set" and another is "collation binary". Which one did you mean
now?

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov