[tarantool-patches] Re: [PATCH] sql: constraints definition among columns in CREATE TABLE()
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Mon Nov 19 15:41:00 MSK 2018
Hi! Thanks for the patch! Please, fix one minor comment
below.
On 18/11/2018 17:31, Roman Khabibov wrote:
> Allow constraints to appear along with columns definitions. Disallow typing
> a constraint name without specifying the constraint and after.
>
> Closes #3504
>
> Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-3504-constraints-create-table
> Issue: https://github.com/tarantool/tarantool/issues/3504
> diff --git a/test/sql-tap/table.test.lua b/test/sql-tap/table.test.lua
> index 8367ec016..65b45de0a 100755
> --- a/test/sql-tap/table.test.lua
> +++ b/test/sql-tap/table.test.lua
> @@ -1,6 +1,6 @@
> #!/usr/bin/env tarantool
> test = require("sqltester")
> -test:plan(57)
> +test:plan(68)
>
> --!./tcltestrunner.lua
> -- 2001 September 15
> @@ -1180,4 +1180,143 @@ test:do_test(
Please, add a test that I can not write multiple 'CONSTRAINT <name>'
in a row.
>
> -- </table-15.1>
> })
More information about the Tarantool-patches
mailing list