[tarantool-patches] [PATCH v3 3/7] iproto: remove iproto functions from execute.c

Vladimir Davydov vdavydov.dev at gmail.com
Thu Nov 29 13:51:49 MSK 2018


On Tue, Nov 27, 2018 at 10:25:40PM +0300, imeevma at tarantool.org wrote:
> To make functions in execute.h more universal we should reduce
> their dependence on IPROTO. This patch removes IPROTO functions
> from execute.c.
> 
> Needed for #3505
> ---
>  src/box/execute.c | 48 ++++++++++++++++++++++++++++++------------------
>  src/box/execute.h | 13 ++-----------
>  src/box/iproto.cc | 10 +++++++++-
>  src/box/xrow.c    | 45 ---------------------------------------------
>  src/box/xrow.h    | 19 -------------------
>  5 files changed, 41 insertions(+), 94 deletions(-)

Well, this doesn't completely liberate execute.c of iproto dependency -
you still use iproto constants, but looking at the following patches
I guess it's OK as those iproto constants are used as map keys when
formatting output and they will be substituted with strings when the
output is formatted as Lua. Pushed to 2.1



More information about the Tarantool-patches mailing list