[tarantool-patches] Re: [PATCH v5 02/12] box: introduce key_def_parts_are_sequential

Kirill Shcherbatov kshcherbatov at tarantool.org
Tue Nov 6 15:14:54 MSK 2018


> They still can:
> Paths foo.bar[0] and foo.bar[1] refer to sequential fields.

Yes, you are right. Generally it should be possible to make correct
is_sequential test for JSON indexes, but - at first - such tests are not trivial
and require already built JSON tree, like the format has. There are two
moments that obstruct it's introducing:
1) in usage scenario tuple_extract_key_slowpath_raw that use
key_def_parts_are_sequential routine doesn't operate with tuple format
entity(we can get around it by doing key_def->has_json_path flag lookup)
2) in key_def prepare step key_def_new/key_def_set_cmp/tuple_extract_key_set
no format object containing JSON path exists in tarantool at all. I don't like temporal JSON tree object
compiled by definitions on key_def_new step to set this unlikely optimization flag.



More information about the Tarantool-patches mailing list