[tarantool-patches] Re: [PATCH v1 0/2] sql: Create special region for parser

[Vladislav Shpilevoy]

LGTM.

On 31/05/2018 18:50, Kirill Shcherbatov wrote:
> Moved sql_parser_create and sql_parser_destroy to sql.h to
> use them not only in DDL.
> Removed SELECTTRACE_ENABLED macro with conditional fields from
> struct Parse to prevent different object sizes across the project.
> Start use own region for parser to avoid unexpected memory releases.
> 
> On 31.05.2018 18:01, Kirill Shcherbatov wrote:
>> Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3438-parser-own-region
>> Issue: https://github.com/tarantool/tarantool/issues/3438
>>
>> Kirill Shcherbatov (2):
>>    sql: remove parser construct, destruct to sql.h
>>    sql: use own region in Parser
>>
>>   src/box/sql.h           | 17 +++++++++++++++++
>>   src/box/sql/build.c     |  6 +++---
>>   src/box/sql/prepare.c   | 11 +++++++++--
>>   src/box/sql/select.c    |  2 +-
>>   src/box/sql/sqliteInt.h | 29 ++---------------------------
>>   src/box/sql/tokenize.c  | 10 ++++++----
>>   6 files changed, 38 insertions(+), 37 deletions(-)
>>
>