[PATCH v2 1/2] memtx: rework background garbage collection procedure
Vladimir Davydov
vdavydov.dev at gmail.com
Thu May 24 09:13:35 MSK 2018
On Wed, May 23, 2018 at 08:56:55PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev at gmail.com> [18/05/22 20:29]:
> > {
> > - index_def_delete(index->def);
> > + /*
> > + * Free index_def after destroying the index as
> > + * engine might still need it.
> > + */
>
> For what?
In this patch I rewrote the code of memtx tree/hash destruction so that
now they check if they are dealing with a primary index explicitly, i.e.
via index->def->iid, see memtx_{hash,tree}_index_destroy. I think it's
easier for understanding. I'll update the comment to reflect this.
>
> > + struct index_def *def = index->def;
> > index->vtab->destroy(index);
> > + index_def_delete(def);
> > }
>
> OK to push.
More information about the Tarantool-patches
mailing list