[tarantool-patches] Re: [PATCH] sql: Fixes op-codes' generation for skip-scan

Ivan Koptelov ivan.koptelov at tarantool.org
Mon May 7 13:42:35 MSK 2018


>This is *acceptable* limit of symbols per line in source code.
>Notice, that for comments in code it is 66 chars. Your fix violates this rule: line is about 84 chars.
>
>Also, we are going to support static types soon,
>so lets add types for all tests in your suite. 
Fix code style violation. Add types.

-- 
Ivan Koptelov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20180507/7ef4cfc7/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-sql-fixes-op-codes-generation-for-skip-scan.patch
Type: application/x-patch
Size: 5766 bytes
Desc: not available
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20180507/7ef4cfc7/attachment.bin>


More information about the Tarantool-patches mailing list